Repository navigation
Reduce inputs for remote actions - #4384
Open
patrickmscott wants to merge 1 commit into
Open
patrickmscott wants to merge 1 commit into
patrickmscott wants to merge 1 commit into
Conversation
Similar to bazelbuild#4235, this change reduces the files needed for all rust actions. Rustc, Clippy, Rustdoc and unpretty actions took toolchain.all_files (cargo, clippy-driver, rustdoc, rustfmt, cargo-clippy and the whole C++ toolchain) plus the C++ linker files and runtime libs, for every crate type, and remote executors stage every input of every action. They now take toolchain.compile_files, the sysroot without those tools, and the C++ linker files and runtime libs only where linker inputs already went. Clippy and Rustdoc add their own tool. compile_files also holds dlltool or, on Windows GNU without one, the C++ toolchain's files, where rustc finds the dlltool it runs for rlibs too. toolchain.all_files is unchanged. _symlink_sysroot_tree stripped the target's repository from each path, not the file's own, so files that a target forwards from another repository, such as a main-repository rustc_lib filtering a toolchain's libraries, landed in <sysroot>/external/<repo>/lib instead of <sysroot>/lib, where rustc's $ORIGIN/../lib RUNPATH looks. rustc found librustc_driver only by resolving its own symlink, which fails where inputs are staged as plain files, as on remote executors. Strip each file's own repository instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4235, this change reduces the files needed for all rust actions.
Rustc, Clippy, Rustdoc and unpretty actions took toolchain.all_files (cargo, clippy-driver, rustdoc, rustfmt, cargo-clippy and the whole C++ toolchain) plus the C++ linker files and runtime libs, for every crate type, and remote executors stage every input of every action.
They now take toolchain.compile_files, the sysroot without those tools, and the C++ linker files and runtime libs only where linker inputs already went. Clippy and Rustdoc add their own tool. compile_files also holds dlltool or, on Windows GNU without one, the C++ toolchain's files, where rustc finds the dlltool it runs for rlibs too. toolchain.all_files is unchanged.
_symlink_sysroot_tree stripped the target's repository from each path, not the file's own, so files that a target forwards from another repository, such as a main-repository rustc_lib filtering a toolchain's libraries, landed in /external//lib instead of /lib, where rustc's $ORIGIN/../lib RUNPATH looks. rustc found librustc_driver only by resolving its own symlink, which fails where inputs are staged as plain files, as on remote executors. Strip each file's own repository instead.