Skip to content

Migrate cdylib_name_analysis_test.bzl to rules_testing - #4377

Merged
inzombieack merged 1 commit into
bazelbuild:mainfrom
inzombieack:cdylib-name-analysis-to-rules-testing
Nov 5, 2026
Merged

inzombieack merged 1 commit into
bazelbuild:mainfrom
inzombieack:cdylib-name-analysis-to-rules-testing

Conversation

@inzombieack

Copy link
Copy Markdown
Collaborator

Migrates //test/unit/cdylib_name:cdylib_name_analysis_test.bzl from @bazel_skylib//lib:unittest.bzl (analysistest) to @rules_testing:

  • Replaces analysistest.make and asserts with analysis_test, test_suite, and env.expect subjects.
  • Wraps the rust_shared_library test fixture in util.helper_target with a test-scoped target name prefix.

Signed-off-by: Taylor Edwards <tayloredwards@google.com>
@inzombieack inzombieack self-assigned this Nov 4, 2026

@krasimirgg krasimirgg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@inzombieack
inzombieack added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@inzombieack
inzombieack added this pull request to the merge queue Nov 5, 2026
Merged via the queue into bazelbuild:main with commit df2a87d Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants