Skip to content

Migrate allocator_library_test.bzl to rules_testing - #4374

Open
inzombieack wants to merge 1 commit into
bazelbuild:mainfrom
inzombieack:allocator-library-test-to-rules-testing
Open

inzombieack wants to merge 1 commit into
bazelbuild:mainfrom
inzombieack:allocator-library-test-to-rules-testing

Conversation

@inzombieack

Copy link
Copy Markdown
Collaborator

Migrates //test/unit/ffi:allocator_library_test.bzl from @bazel_skylib//lib:unittest.bzl (analysistest) to @rules_testing (analysis_test).

Changes

  • Replace analysistest.make and native.test_suite with analysis_test and test_suite from @rules_testing//lib:analysis_test.bzl.
  • Replace asserts.true(env, CcInfo in target_under_test, ...) with env.expect.that_target(target).has_provider(CcInfo).

Signed-off-by: Taylor Edwards <tayloredwards@google.com>
@inzombieack inzombieack self-assigned this Nov 3, 2026

@krasimirgg krasimirgg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@inzombieack
inzombieack added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants