Repository navigation
Pass through -Zallow-features when unstable_rust_features_config is unset - #4373
Open
digit-google wants to merge 1 commit into
Open
digit-google wants to merge 1 commit into
digit-google wants to merge 1 commit into
Conversation
…nset When `unstable_rust_features_config` is None, `-Zallow-features=` flags in `extra_rustc_flags` and `rust_flags` were unconditionally stripped and dropped, silently disabling toolchain- or target-level unstable feature restrictions (such as `-Zallow-features=`). Only extract `-Zallow-features=` flags when `unstable_rust_features_config` is configured, passing them through unchanged otherwise. Fixes bazelbuild#4364
krasimirgg
self-requested a review
November 4, 2026 12:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
unstable_rust_features_configis None,-Zallow-features=flags inextra_rustc_flagsandrust_flagswere unconditionally stripped and dropped, silently disabling toolchain- or target-level unstable feature restrictions (such as-Zallow-features=).Only extract
-Zallow-features=flags whenunstable_rust_features_configis configured, passing them through unchanged otherwise.Fixes #4364