Repository navigation
Fix elided_lifetimes_in_paths warnings in process_wrapper - #4372
Open
digit-google wants to merge 1 commit into
Open
digit-google wants to merge 1 commit into
digit-google wants to merge 1 commit into
Conversation
When building process_wrapper in the exec configuration with toolchains that enable -Wrust-2018-idioms (or -Welided-lifetimes-in-paths) without --cap-lints=allow, un-lifetimed fmt::Formatter references emit warnings. Spell out the anonymous lifetime (fmt::Formatter<'_>) across util/process_wrapper.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building process_wrapper in the exec configuration with toolchains that enable -Wrust-2018-idioms (or -Welided-lifetimes-in-paths) without --cap-lints=allow, (as is done in the Fuchsia build) un-lifetimed fmt::Formatter references emit unpleasant warnings. This PR removes them.
Spell out the anonymous lifetime (fmt::Formatter<'_>) across util/process_wrapper.