feat(eval): rename --evaluator to --evaluators - #2264
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Straightforward, well-scoped flag rename from --evaluator to --evaluators across the eight commands that accept a variadic list of evaluator IDs. I checked the whole tree and everything is consistent:
- All eight handlers updated: flag definition, validation error message, and
flags["…"]read site. - All corresponding test files (including fixture tests and
test.eachregex matchers like/--evaluator/→/--evaluators/) updated. - No leftover
flag("evaluator", …),flags["evaluator"], or"--evaluator"argv references remain insrc/. - The two "deliberately left alone" spots check out:
project removeuses"evaluator"as a resource-type enum value (src/handlers/project/remove/index.ts:49), andsupportedTuiCommands("evaluator", …)insrc/handlers/eval/index.tsxnames a subcommand, not a flag. - No README or docs references to the old flag needed updating.
- Since fixture hashes cover the SDK request rather than argv, no recordings need to be re-captured — as the description notes.
- No behavior change → no new telemetry surface required.
Since the refactor CLI has not shipped GA, skipping a deprecated alias is reasonable. Nothing blocking; good to merge.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2264 +/- ##
=========================================
Coverage 97.04% 97.04%
=========================================
Files 566 566
Lines 39353 39353
=========================================
Hits 38190 38190
Misses 1163 1163 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
added this pull request to stack #2270
September 10, 2026 15:43
The flag has always been variadic — every one of these commands accepts a list of evaluator IDs — but the singular name read as though it took one. Renamed across all eight commands that take the list, so the CLI does not end up with two spellings for the same concept. No deprecated alias: the refactor CLI has not shipped GA, so there are no scripts to keep working. Left alone deliberately: `project remove --evaluator`, where the value names a resource *type* rather than a list, and the `eval` router's TUI subcommand names, which are command names rather than flags.
jariy17
force-pushed
the
feat/rename-evaluators
branch
from
September 10, 2026 15:53
53c0989 to
289eeae
Compare
jariy17
marked this pull request as ready for review
September 10, 2026 15:53
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
nborges-aws
approved these changes
Sep 10, 2026
notgitika
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several commands accept multiple evaluators using the
--evaluatorflag. Because the flag name is singular, it's easy to mistake it for a single-value option. This pr changes it to--evaluatorsflag.What changed
Renamed across all eight commands that take the list, so the CLI doesn't end up carrying two spellings for the same concept:
eval batch-evaluation evaluateeval batch-evaluation simulateeval online-eval createeval online-eval updateeval ondemand evaluateeval ondemand simulateeval batch-insights runproject add online-evalVerification
bun test— 3179 pass, 0 fail (224 files)bun run typecheck,bun run lint:check,bun run format:check— cleanflag("evaluator", …),flags["evaluator"], or"--evaluator"argv left anywhere insrc/Fixture tests needed no rehashing: recorded hashes cover the SDK request, not the argv, so a flag rename doesn't move them.