Repository navigation
Revert "Support FEV_DATASETS_PREFIX for S3 dataset paths (#184)" - #198
Merged
Merged
Conversation
This reverts commit 3d03d1c.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts #184, so
FEV_DATASETS_PREFIXonce again only redirects tasks with adataset_config(HF Hub datasets), as it did in v0.10.0.The problem with #184 is that one variable was doing two jobs. HF configs and S3
dataset_paths need different mirror roots, so no single prefix works for both kinds of task. The S3 remap only helps tasks that use custom S3 paths, and their owners can just edit their own configs. #184 hasn't been released yet, so the revert breaks nothing that has shipped. This supersedes #197.Test plan
pytest test/test_task.pypasses