Repository navigation
fix(bench): pass --allow-declined in ooc whole-env check-lean benchmark - #685
Merged
Merged
Conversation
johnchandlerburnham
enabled auto-merge
November 7, 2026 14:40
arthurpaulino
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(bench): pass --allow-declined in ooc whole-env check-lean benchmarkSummary
Fixes the failing
ooc-InitStd-execute,ooc-Lean-execute, andooc-Mathlib-executejobs inbench-main.ymlafter PR #677 switchedoocfromix check-rstoix check-lean(IxC).Background & Problem
ix bench run --backend oocruns twoix check-leanpasses per environment:ix check-lean <ixe> --anon --json <out> --json-name <env> --per-const <out>.perconst.csv).benchConstants(ix check-lean <ixe> --anon --consts-file <namesFile> --json <out>).While all per-constant rows pass with
"status": "ok", upstream Lean libraries (InitStd.ixe,Lean.ixe,Mathlib.ixe) contain declarations outsideIxC's fragment that receiveoutcome == "decline"(and dependents that receiveoutcome == "blocked"), with 0 kernel rejections (outcome == "reject"):InitStd.ixe(99,519subjects):99,514pass (922typed), 0reject,5decline/blocked(Lean.trustCompiler+ its 4 native-eval dependents).Lean.ixe(173,337subjects):173,250pass (3,415typed), 0reject,87decline/blocked(the 5InitStdsubjects + 5unsafe inductiveblocks + 7unsafe defs whose type check requires unfolding a tier definition + their blocked dependents).Mathlib.ixe(~672,938constants): importsInit,Std, andLean, inheriting the samedecline/blockedset with 0reject.Because default
ix check-leantreats any!successoutcome (decline,blocked, orreject) as a refusal (exit 3,"status": "rejected"), the whole-env row was written with"status": "rejected", causingix bench run's final gate to fail with exit3andix bench bmfto drop the whole-env row.Solution
Ix/Cli/CheckLeanCmd.lean:--allow-declined(CheckCfg.allowDeclined) andCheckReport.hasReject(r.targets.any (·.outcome == "reject") || r.rows.any (·.outcome == "reject")).--allow-declined,check-leanruns in record-check mode: it toleratesdeclineandblockedoutcomes (when no target or support record in the closure hasoutcome == "reject"), skipscheckWholewhole-artifact admission, rejects--host-out/--host-storewith exit2, and still fails with exit3("status": "rejected") on any genuine kernel or readerreject.ix check-leanbehavior and exit codes (0,2,3,4,5) are unchanged.Ix/Cli/BenchCmd.lean:--allow-declinedonooc's whole-envix check-leaninvocation while keeping the per-constant--consts-fileclosure runs strict.Tests/Ix/Kernel/CheckLeanCli.lean&docs/:--allow-declined(decline/blockedrows markedok,rejectstill exits3/rejected, unbound whole run skips whole-artifact admission and exits0/ok, and--host-storeexits2) and document the flag indocs/kernel.mdanddocs/benchmarking.md.Verification
IxTests bench-measures kernel-check-lean-cli(24 process controlspassing).ix bench run --backend ooc --env InitStd --mode execute --ixe ./InitStd.ixe+ix bench bmf(exits0; all 8 rowsstatus: okand emitted to BMF).ix bench run --backend ooc --env Lean --mode execute --ixe ./Lean.ixe+ix bench bmf(exits0; bothLeanandLean.Jsonrowsstatus: okand emitted to BMF).