Repository navigation
feat(stereo-split): emit archebase topic layout in output MCAP - #234
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Summary
Make the stereo-split job write the Archebase Ego topic layout (
/archebase/<part>/<data_stream>[/<transport>]) in its output MCAP instead of mirroring the legacy DECXIN topic names.Motivation
The topic naming specification requires normalized topic names such as
/archebase/cam_0/image_raw/h264, not just an/archebaseprefix on/decxin/.... See the Feishu spec: https://archebase.feishu.cn/wiki/RWnrw7cPQiqqL1kqUE4csUeGnghThe existing prefix-compatibility work (PR #232) only preserved an optional
/archebaseprefix and still emitted/archebase/decxin/left_rgb/h264-style names. This PR implements the actual rename.Changes
Output mapping:
/archebase/cam_0/image_raw/h264/archebase/cam_1/image_raw/h264/archebase/imu_0/imu/archebase/device/serial_numberModified Files
jobs/stereo-split/convert_mcap_stereo_h264.py- separate input topics from output topics; rename copied channels in both the joined-conversion and split-H.264 timestamp-repair paths; detect rename collisions.jobs/stereo-split/run_processing.py- build the converter config with canonical output topics, updatemetadata.yaml, and addtopic_layout: archebase_v1to the processing manifest.internal/services/stereosplit/reconciler.go- select the QA topic contract fromtopic_layout(legacy/absent vsarchebase_v1) and reject unknown layouts.internal/services/stereosplit/manager_test.go- cover the new layout, explicit legacy layout, and unknown layout rejection.jobs/stereo-split/tests/test_run_processing.py- assert canonical topics for joined and split-H.264 inputs, including the renamed serial topic.jobs/stereo-split/README.md- document the new output layout.Type of Change
Impact Analysis
Breaking Changes
Consumers of newly generated stereo-split output MCAPs must use the new topic names. Existing derivatives and in-flight generations are unaffected because each generation stays pinned to its immutable image digest.
Backward Compatibility
topic_layoutor usetopic_prefix.topic_layout: archebase_v1explicitly, so Keystone can support both layouts during rollout.Follow-up coordination
The following consumers still hardcode legacy
/decxin/...names and must be updated before the new image is enabled for their workflows:motion-store/hilbert-storeE40KDescriptorcolor_aberration_fix/calibrate_stereo.pyimu_dedup.pyTesting
Test Environment
jobs/stereo-split/requirements.txtTest Cases
Manual Testing Steps
go test ./internal/services/...(passes).91 passed.ego-portal-stereo_ep-200534_20260922T065845Z.mcap; the output MCAP contains exactly the four canonical topics above, and the manifest reportstopic_layout: archebase_v1.Test Coverage