Skip to content

refactor(coreai_utils): use raw CoreAI ops in the sparsity pass #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guru-desh merged 3 commits into from
Oct 29, 2026
Merged

refactor(coreai_utils): use raw CoreAI ops in the sparsity pass #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25af8cd
refactor(coreai_utils): use raw CoreAI ops in the sparsity pass
guru-desh Oct 28, 2026
f4acedd
refactor(coreai_utils): import the raw sparse ops by name
guru-desh Oct 28, 2026
ace2ffb
refactor(coreai_utils): drop the comment on the raw sparse imports
guru-desh Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreai_opt/coreai_utils/_coreai_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ def _import_coreai() -> tuple:
DebugInfo,
TensorType,
blockwise_shift_scale,
build_sparse_with_bitmask,
cast as authoring_cast,
float4_e2m1fn,
float8_e4m3fn,
Expand All @@ -146,12 +145,15 @@ def _import_coreai() -> tuple:
float16,
float32,
lut_to_dense,
sparse_with_bitmask_to_dense,
)
from coreai.authoring.constant import constant as authoring_constant # noqa: PLC0415
# isort: on

from coreai._compiler.dialects import coreai as coreai_dialect # noqa: PLC0415
from coreai._compiler.dialects.coreai import ( # noqa: PLC0415
build_sparse_with_bitmask,
sparse_with_bitmask_to_dense,
)
from coreai._compiler.dialects.coreai.constant import create_elements_attr # noqa: PLC0415
from coreai._compiler.ir import ( # noqa: PLC0415
BoolAttr,
Expand Down
4 changes: 2 additions & 2 deletions src/coreai_opt/coreai_utils/passes/weight_sparsification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ def replace_weight_with_compression_op(op: Any) -> Any:
sparse_tensor = _build_sparse_with_bitmask(
values=nonzero_data_const,
bitmask=mask,
)._to_mlir()
compressed_weight = _sparse_with_bitmask_to_dense(sparse_tensor)._to_mlir()
)
compressed_weight = _sparse_with_bitmask_to_dense(sparse_tensor)

if require_dequantization:
compressed_weight = _blockwise_shift_scale(
Expand Down
Loading