fix: parse JSON API errors with content type parameters - #215
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JSON error response with
Content-Type: application/json; charset=utf-8currently loses its API error code and message because the response parser requires an exact header match. Compare the media type independently of parameters and casing so both clients retain the structured error details.Adds synchronous and asynchronous regression coverage for parameterized and mixed-case JSON media types, including preservation of Retry-After. All four new subcases fail before the fix and pass afterward.
Validation: 223 tests and all four new subcases pass. The remaining existing live OCSP verification test fails while contacting Apple's OCSP service in this environment, including a retry with network access.
git diff --checkpasses.