Repository navigation
test: add proxy server conformance coverage - #464
Merged
Merged
Conversation
Member
|
Looks good, thanks for the addition |
jancurn
added a commit
that referenced
this pull request
Oct 26, 2026
Small follow-up to #464 covering the nits from its review. Test-only, no runtime change. - List `dns-rebinding-protection` in the conformance coverage table in `test/conformance/README.md` - Make the proxy lane honour the workflow's `verbose` input, like the client lane - Spawn `npx` through a shell on Windows, where it is a `.cmd` shim that Node refuses to spawn directly (EINVAL) Verified locally: the lane still passes 2/2 with `--verbose --output-dir` passed through, lint, build and unit tests are green. Refs #334 --- _Generated by [Claude Code](https://claude.ai/code/session_01BbA1fNDr3b1HbZc7Q6qFvo)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of issue #334.
Adds the suggested first server conformance scenario for
mcpc connect --proxy, checking invalid Host/Origin rejection and valid localhost acceptance through an isolated local chain.The default reusable conformance workflow includes this lane, so it also gates releases. It follows the existing unpinned
npx -yconvention; local validation pinned conformance 0.1.16.Docker Linux ARM64 / Node 24: build, lint (24 existing warnings), 1,345 unit tests, five consecutive conformance runs (2/2 each), and the existing proxy E2E suite pass. A direct-server negative control fails as expected; failure cleanup also passes.
Remaining server scenarios and macOS/Windows/Bun checks are not covered.
Refs #334.