Repository navigation
Align skills types with ext-skills#157 - #457
Merged
Merged
Conversation
The spec's alignment with the 2026-07-28 base schema made ReadResourceDirectoryResult cacheable and added an optional _meta to Skill. Type both, reject a non-object _meta, and return the caching hints from the e2e test server's directory read. Request _meta, also required by that revision, is already stamped by the SDK on every 2026-07-28 request. No changelog entry: the directory read command prints only the children, so the hints never reach a user, and entry _meta already passed through. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-skills#157 aligned the Skills spec with the 2026-07-28 base schema. For a client this means
ReadResourceDirectoryResultextendsCacheableResult(ttlMs,cacheScope),Skillhas an optional_meta, and every request carries_meta.src/lib/types.ts: type the caching hints on the directory read result and_metaonSkill.src/core/skills-schema.ts: reject a skill entry whose_metais not an object.test/e2e/server/index-v2.ts: the test server returns the hints fromresources/directory/read.test/unit/core/skills-schema.test.ts: cover_metapass-through and rejection, and the hints on directory reads.Request
_metaneeded no change: SDK 2.3.1 stamps it on every 2026-07-28 request.No changelog entry.
resources-directory-readprints only the children, so the hints never reach a user, and entry_metaalready passed through to--json.Verified with
tsc,eslint, the skills unit tests, andtest/e2e/suites/basic/skills.test.shagainst the modern test server.Also tested with the live Cloudflare MCP server which serves skills.
AI Disclosure: I used a coding agent to make these changes but have read and understand them.