slice_stale_generation.test.py: Accept either abort shape - #13596
Open
bneradt wants to merge 1 commit into
Open
Conversation
The test pinned one Proxy Verifier parse state, PARSE_INCOMPLETE, for a transaction that slice aborts. How far slice got before aborting decides what the client sees, so under load the client instead reads a complete response header whose body never arrives, and Proxy Verifier reports a Content-Length body underrun. This patch accepts either shape, since both mean the client received no complete response, which is what the test checks. The sibling cold child run already asserts only that the transaction failed. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
bneradt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test pinned one Proxy Verifier parse state, PARSE_INCOMPLETE, for a
transaction that slice aborts. How far slice got before aborting decides
what the client sees, so under load the client instead reads a complete
response header whose body never arrives, and Proxy Verifier reports a
Content-Length body underrun.
This patch accepts either shape, since both mean the client received no
complete response, which is what the test checks. The sibling cold child
run already asserts only that the transaction failed.