Repository navigation
THRIFT-6388: Make the Go package name from an IDL file name a valid identifier - #3968
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
mergeable
Bot
added
golang
slachiewicz
marked this pull request as ready for review
September 27, 2026 17:27
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
fishy
approved these changes
Oct 18, 2026
slachiewicz
force-pushed
the
THRIFT-6388
branch
from
October 19, 2026 23:25
3bdb4c1 to
23fea07
Compare
slachiewicz
force-pushed
the
THRIFT-6388
branch
from
October 20, 2026 22:29
23fea07 to
7611d41
Compare
…dentifier Client: go Without a namespace go, the Go generator named the package after the IDL file, so a file name containing a hyphen, such as Apache Accumulo's compaction-coordinator.thrift, gave a package name that does not compile. The generator now replaces characters that a Go identifier cannot hold with '_', keeping '.', which separates nested packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slachiewicz
force-pushed
the
THRIFT-6388
branch
from
October 21, 2026 12:47
7611d41 to
66da039
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a
namespace go, the Go package is named after the IDL file; characters a Go identifier cannot hold, such as-, now become_, and.still separates nested packages. lib/go/test gains Hyphenated-Name.thrift, built together with its-remotestub.Verified:
make -C lib/go check,make -C test/go checkandmake distpass; Apache Accumulo's compaction-coordinator.thrift now generates packagecompaction_coordinator, which builds.