docs: drop hardcoded test-class counts from the review guides - #1886
Merged
Conversation
CLAUDE.md and .github/skills/code-review/SKILL.md each stated how many test classes use the JUnit 3 and JUnit 4 styles. Both were already stale: the XWorkTestCase count reads ~114 and 117 against an actual 117, and the org.junit.Test count reads ~210 and 212 against an actual 215. The numbers carry no review weight — what matters is that both styles are current, that a new test must match the file it joins, and that there are zero org.junit.jupiter imports. That last one is load-bearing and stays. The class counts only ever move in one direction, in two files, with nothing watching them, so remove them rather than resync them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AtyHU8BzNmeZNncXRu7yjB
lukaszlenart
marked this pull request as ready for review
August 30, 2026 15:21
lukaszlenart
enabled auto-merge (squash)
August 30, 2026 15:21
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1885 and #1876.
CLAUDE.mdand.github/skills/code-review/SKILL.mdeach stated how many test classes use the JUnit 3 and JUnit 4 styles. Both were already stale:SKILL.mdCLAUDE.mdextends XWorkTestCaseimport org.junit.Testorg.junit.jupiterBoth were hedged with "around"/"~", so neither was wrong today. But a count that only moves in one direction, duplicated across two files with nothing watching it, is a drift surface for no benefit — the numbers carry no review weight.
What matters is retained: both styles are current, a new test must match the file it joins, and there are zero
org.junit.jupiterimports. That last one is the load-bearing claim and it stays in both files.The two files serve different consumers —
CLAUDE.mdfor Claude Code,.github/skills/for GitHub Copilot code review (#1876) — so they are updated in step rather than merged.Documentation only — no ticket, per the
docs:convention inCLAUDE.md. No code, build or CI files touched.🤖 Generated with Claude Code
https://claude.ai/code/session_01AtyHU8BzNmeZNncXRu7yjB