SOLR-18401: HttpJettySolrClient: detect if request wasn't sent; retry - #4805
SOLR-18401: HttpJettySolrClient: detect if request wasn't sent; retry#4805dsmiley wants to merge 4 commits into
Conversation
… retry-able CloudSolrClient & LBSolrClient will detect it.
There was a problem hiding this comment.
The try-catch logic here is a challenge; not sure if we can make it elegant/clearer.
| */ | ||
| public class RequestNotSentException extends IOException { | ||
|
|
||
| private static final long serialVersionUID = 1L; |
There was a problem hiding this comment.
Hmm; I should probably remove
There was a problem hiding this comment.
nah it's common/standard actually and of course harmless
| private static final LBSolrClient.Endpoint FIRST = | ||
| new LBSolrClient.Endpoint("http://127.0.0.1:1/solr"); | ||
| private static final LBSolrClient.Endpoint SECOND = | ||
| new LBSolrClient.Endpoint("http://127.0.0.1:2/solr"); |
There was a problem hiding this comment.
I recall we have a test fixture/utility with bogus URLs we should use instead.
There was a problem hiding this comment.
yes (in STCJ4) but they needn't be referenced so I didn't
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
Looks good to me. I wish these if/else statements could get easier, but not a blocker for the PR.
|
Thanks for the review. Tweaked the odd naming choices in the test to be clearer to me. |
2 participants
CloudSolrClient & LBSolrClient will detect it and retry.
https://issues.apache.org/jira/browse/SOLR-18401 (read it; very detailed)