SOLR-18399: Ship ui-grid icon fonts with the Admin UI - #4802
Open
janhoy wants to merge 1 commit into
Open
Conversation
ui-grid.min.css references fonts/ui-grid.{woff,ttf,eot,svg}, but the font
files were never checked in, so grid icons on the SQL screen rendered as
boxes and the browser logged 404s. Add the font files from the same
angular-ui-grid 4.10.0 release the shipped CSS/JS come from, and drop the
console-error filter that worked around the 404.
epugh
approved these changes
Aug 25, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Tested it locally and it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18399
ui-grid.min.css references
fonts/ui-grid.{woff,ttf,eot,svg}, but the font files were never checked in, so grid icons on the Admin UI SQL screen render as boxes and the browser logs 404s for the fonts.Solution
Add the four icon font files to
solr/webapp/web/css/angular/fonts/, taken from the same angular-ui-grid 4.10.0 release (MIT) that the already-shippedui-grid.min.css/ui-grid.min.jscome from. The war task packages everything underweb/, so they ship automatically.Also remove the console-error filter in
AdminUiTestBasethat suppressed the font 404 as a known issue.Tests
AdminUiSqlScreenTestpasses with the 404-filter removed. As a negative control, deleting the fonts again makes the test fail with the exactfonts/ui-grid.woff/.ttf404 console errors, proving the test exercises the font requests. Full:solr:webapp:checkwith-Ptests.selenium=true(all 53 Admin UI browser tests, RAT, spotless) passes.No changelog entry: user-invisible packaging fix for the legacy Admin UI.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.