Normalize frontpage directory parameters before rendering the bundled theme - #169
Open
snoopdave wants to merge 1 commit into
Open
Normalize frontpage directory parameters before rendering the bundled theme#169snoopdave wants to merge 1 commit into
snoopdave wants to merge 1 commit into
Conversation
… theme The bundled frontpage directory filters its listing by a letter parameter. It now accepts that parameter only when it matches one of the directory's own A-Z keys, falling back to the full listing otherwise (as a missing parameter already did), and HTML-escapes it in the heading. The sibling directory template resolves its weblog handle before use and builds the back-link from the resolved weblog rather than the request parameter. Adds FrontpageDirectoryRenderingTest and tightens the weblog letter-map test to assert the complete A-Z key set the template now depends on. Claude-Session: https://claude.ai/code/session_01A1fhY1E2PCFU6UAPXu2WtV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled frontpage theme's blog-directory page filters its listing by a
letterrequest parameter and builds a back-link from aweblogparameter.This change validates and normalizes both before use and escapes them at output.
What changed
to be a key in the business layer's weblog-letter map.
without redirecting, erroring, or echoing the rejected value.
weblogparameter to an existing weblog and build the back-linkfrom the resolved handle, escaped at output.
Tests
the same group.
full listing and do not appear in the response, raw or encoded.