Separate submitted and response salts in UI filters - #167
Open
snoopdave wants to merge 1 commit into
Open
Conversation
Validate the salt submitted with the request rather than a request attribute, and run validation before the response salt is generated. Move multipart validation into a Struts interceptor after the upload interceptor, since filters cannot read multipart fields. Drop the unused salt.ignored.urls bypass. Claude-Session: https://claude.ai/code/session_01A1fhY1E2PCFU6UAPXu2WtV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roller's UI CSRF protection uses two salt filters: one checks the token
submitted with a request, the other generates the token for the next response.
This change gives each filter a single responsibility and corrects the order in
which they run.
What changed
saltvalue submitted with the request.only after a successful validation, and terminate rejected POSTs without a
replacement token.
*.rolvalidation to an interceptor that runs immediatelyafter the upload interceptor, and reject non-Struts multipart requests that
lack a submitted token.
salt.ignored.urlssetting and itsisIgnoredURL()helper, whichdid not match the shipped values correctly.
Tests
saltis rejected; one valid tokensucceeds once and a second use of the same token fails.
already-used tokens, exercised on the supported Tomcat deployment and the
repository Jetty test setup.