Fix flaky ConnectionFailTest: restore fd limit in SetUp - #612
Merged
Conversation
ConnectionFailTest lowers the process soft fd limit (RLIMIT_NOFILE) in a loop and never restores it, so a test leaves the limit as low as ~8 for the next one. The next test's SetUp() then makes an HTTP request to create the partitioned topic, and curl can intermittently fail to open a socket (res: -1) when the previous client's async connection teardown still holds file descriptors. Restore the soft limit to the hard limit in SetUp() before making the HTTP request.
lhotari
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ConnectionFailTestfails intermittently in CI, e.g. https://github.com/apache/pulsar-client-cpp/actions/runs/33217535403/job/99014404956:The test lowers the process soft fd limit (
RLIMIT_NOFILE) in a loop and never restores it, so a test leaves the limit as low as ~8 for the next one (the failing run'stest/0ended withUpdated fd limit to 8). The next test'sSetUp()then makes an HTTP request to create the partitioned topic, and curl can intermittently fail to open a socket (res: -1) when the previous client's async connection teardown still holds file descriptors. Sincerun-unit-tests.shruns this suite with--gtest_repeat=20and no retry, a single flake fails the job.Modifications
Restore the soft fd limit to the hard limit in
SetUp()before making the HTTP request.