Repository navigation
Conversation
krickert
force-pushed
the
OPENNLP-1991-feedforward-dependency-parser
branch
from
October 11, 2026 15:14
c1e5fa1 to
f0d8072
Compare
krickert
force-pushed
the
feat/GH-1469-feedforward-parser-cli
branch
from
October 11, 2026 15:14
f21d77b to
2295a6b
Compare
krickert
force-pushed
the
OPENNLP-1991-feedforward-dependency-parser
branch
from
October 11, 2026 22:30
f0d8072 to
ff09c3f
Compare
krickert
force-pushed
the
feat/GH-1469-feedforward-parser-cli
branch
from
October 11, 2026 22:31
2295a6b to
d323630
Compare
krickert
force-pushed
the
OPENNLP-1991-feedforward-dependency-parser
branch
from
October 14, 2026 03:21
ff09c3f to
851484e
Compare
Contributor
Author
|
Fixing this now |
krickert
force-pushed
the
feat/GH-1469-feedforward-parser-cli
branch
from
October 14, 2026 05:57
d323630 to
da14618
Compare
Base automatically changed from
OPENNLP-1991-feedforward-dependency-parser
to
main
October 15, 2026 13:06
Contributor
Author
|
rebasing |
FeedforwardDependencyParserTrainer trains a FeedforwardDependencyModel from the depparse sample formats. The -params file takes the trainer keys, and without a file the trainer defaults apply. -refineParams refines the model with beam search; with -baseModel the tool refines a saved model instead of training one. FeedforwardDependencyParser parses tagged lines from standard input and FeedforwardDependencyParserEvaluator logs UAS and LAS in the format of the maxent tools. Both take -beamSize, defaulting to the beam size a refined model records in the manifest, or 1. The manual's dependency chapter documents the tools. ModelLoader now reports a model of another component as "Model has invalid format" for all loaders instead of a raw IllegalArgumentException. The CoNLL-U output loop and the scoring step are shared with the maxent tools, and the depparse CLI tests use one fixture class. Signed-off-by: Kristian Rickert <kristian@apache.org> Co-authored-by: Claude Code 2.1.296 (Opus 5.5) <noreply@anthropic.com>
krickert
force-pushed
the
feat/GH-1469-feedforward-parser-cli
branch
from
October 15, 2026 13:34
da14618 to
3dbca22
Compare
krickert
marked this pull request as ready for review
October 15, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feedforward dependency parser from #1323 can now be trained, run, and evaluated from the command line, like the existing maxent
DependencyParsertools.Fixes #1469.
The new tools:
FeedforwardDependencyParserTrainertrains a model from the same sample formats asDependencyParserTrainerME. The-paramsfile takes theFeedforwardDependencyTrainerkeys, and keys not given take the trainer's defaults.-refineParamsrefines the trained model with beam search, and-baseModelrefines an existing model instead of training a new one.FeedforwardDependencyParserparsestoken_TAGlines from standard input and prints CoNLL-U.FeedforwardDependencyParserEvaluatorreports UAS and LAS in the same format asDependencyParserEvaluator.The parser and the evaluator take an optional
-beamSize. Without it, they use the beam size a refined model records, or parse greedily.ModelLoadernow reports a model of another component as "Model has invalid format" for all CLI loaders, instead of failing with anIllegalArgumentException. The maxent and feedforward tools share the CoNLL-U output, scoring, and parameter loading code, and the maxent tools behave as before. There is no cross-validation tool, since no feedforward cross validator exists.Tests cover the output of each tool, refinement, the beam size rules, and the rejected arguments, including exit codes, messages, and that no model file is written on failure. The dependency parser chapter of the manual gets a command-line section.