Repository navigation
GH-1458: Parse name-finder tags and parse-tree strings without regular expressions - #1459
Merged
Merged
Conversation
Replaces the character literals in the new scans with named constants and reuses UnicodeWhitespace.SPACE and CARRIAGE_RETURN in StringUtil.isAsciiWhitespace.
mawiesne
reviewed
Oct 9, 2026
Valid inputs, the rejected empty type and invalid inputs are now separate tests with explicit expected values; the former regular expressions remain as cross-checks.
mawiesne
approved these changes
Oct 9, 2026
mawiesne
left a comment
mawiesne
left a comment
Contributor
There was a problem hiding this comment.
PR in good shape now. +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameSample start tags and Parse labels, function tags and tokens are now recognised by character scans that reproduce the former expressions exactly, pinned by parameterized tests that use the old patterns as oracles. The forbiddenapis guard in #1348 depends on this change. Because training-data parsing for the name finder and parser goes through this code, an eval build is advisable before merging.
Fixes #1458