HTTPCORE-798: Make socket channel creation customizable - #690
Merged
Conversation
arturobernalg
force-pushed
the
HTTPCORE-798
branch
from
August 22, 2026 14:40
2d1823f to
95095e3
Compare
ok2c
reviewed
Aug 23, 2026
| * @since 5.5 | ||
| */ | ||
| @FunctionalInterface | ||
| public interface SocketChannelFactory { |
Member
There was a problem hiding this comment.
@arturobernalg Can't we reuse already existing IOFunction interface here instead of this one?
Member
Author
There was a problem hiding this comment.
@arturobernalg Can't we reuse already existing
IOFunctioninterface here instead of this one?
@ok2c Good point, I’ll reuse it and remove SocketChannelFactory.
arturobernalg
force-pushed
the
HTTPCORE-798
branch
from
August 23, 2026 09:57
978fe93 to
bc9f0cd
Compare
ok2c
reviewed
Aug 23, 2026
| try { | ||
| socketChannel = openSocketFor(sessionRequest.remoteAddress); | ||
| } catch (final IOException ex) { | ||
| socketChannel = Args.notNull(socketChannelFactory.apply(sessionRequest.remoteAddress), "Socket channel"); |
Member
There was a problem hiding this comment.
@arturobernalg This looks odd. Why Args#notNull here? It is not an argument and it is never null
Add a socket channel factory extension point to the connecting I/O reactor.
arturobernalg
force-pushed
the
HTTPCORE-798
branch
from
August 24, 2026 06:41
64361f8 to
537f186
Compare
ok2c
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a socket channel factory extension point to the connecting I/O reactor.