[rust][python] Add LICENSE and NOTICE to the published artifacts - #4090
Merged
fresh-borzoni merged 1 commit intoAug 25, 2026
Merged
Conversation
Member
Author
|
@leekeiabstraction @charlesdong1991 Appreciate a review, related to release requirements 🙏 |
charlesdong1991
approved these changes
Aug 24, 2026
fresh-borzoni
force-pushed
the
rust-license-python-crate
branch
from
August 25, 2026 13:54
552c55c to
5870b38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4091
Follow-up to #3803 - the python/crates check I said I'd do separately.
Neither the PyPI wheel/sdist nor the
fluss-rs.crate carries LICENSE or NOTICE:git archiveroots atfluss-rust/and cargo roots at the crate dir, so neither inherits what #3803 added.The sdist even bundles the Flink/Kafka/Paimon-derived sources that LICENSE attributes.
Adds both files to
bindings/pythonandcrates/fluss, declares them inpyproject.toml(maturin ships them only whenlicense-fileslists them), and fails the two release workflows if an artifact is missing either.