refactor: remove the rand runtime dependency and add common random bit function - #264
Merged
Merged
Conversation
tisonkun
enabled auto-merge (squash)
September 2, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
randruntime dependency from the publisheddatasketchescrate and add our own random generator.KLL and REQ only require a random boolean when choosing which half of a
compaction range to promote. This PR replaces those calls with a small,
crate-private
random_bit()implementation backed by a thread-localSplitMix64 generator.
Closes #203
Changes
RandomStaterandom_bit()for KLL and REQ compaction decisionsrandfrom thekllandreqfeature dependency listsrandfrom the published library's normal dependenciesThe workspace still uses
randfor benchmarks, but downstream users of thedatasketchescrate no longer pull it in.Compatibility
This does not change the public API or serialization format.
KLL and REQ compaction remain randomized. The new generator only replaces the
source of the random coin used to select which items are promoted.
Testing
cargo x checkcargo x lintcargo x test