Repository navigation
test: migrate expect-test snapshots to insta - #64
Merged
Merged
Conversation
gabotechs
marked this pull request as draft
October 11, 2026 17:38
NoahKusaba
approved these changes
Oct 11, 2026
gabotechs
marked this pull request as ready for review
October 12, 2026 06:30
gabotechs
force-pushed
the
gabotechs/move-to-insta
branch
from
October 12, 2026 06:32
ca3b783 to
cbb64ea
Compare
gabotechs
force-pushed
the
gabotechs/move-to-insta
branch
from
October 13, 2026 07:48
cbb64ea to
3efe75f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the integration tests’
expect-testassertions with inlineinstasnapshots and remove the directexpect-testdev-dependency. Use Arrow’spretty_format_batchesfor result snapshots and schema snapshots with one field per line to preserve assertions on types, nullability, and field metadata. Empty metadata tables also assert that every batch has zero rows, and the insert query usesORDER BYto keep results deterministic.Update the snapshot review command in
AGENTS.md. The updated Iceberg dependency no longer requiresexpect-test, so it anddissimilarare also removed from the lockfile.