Migrations triggered by Maintenance (system) not reported on VM events list

[abh1sar]

Description

VM migrations triggered by HA (e.g. as a result of host maintenance) were not showing up in the VM events list, since HighAvailabilityManagerImpl scheduled and ran these migrations without emitting any action events, unlike user-initiated migrations.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 17.89474% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.78%. Comparing base (5dcb8ab) to head (5e4e748).
⚠️ Report is 50 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...java/com/cloud/ha/HighAvailabilityManagerImpl.java	25.00%	46 Missing and 5 partials ⚠️
...rc/main/java/com/cloud/event/dao/EventDaoImpl.java	0.00%	16 Missing ⚠️
...c/main/java/com/cloud/utils/db/GenericDaoBase.java	0.00%	8 Missing ⚠️
...rc/main/java/com/cloud/event/ActionEventUtils.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13931      +/-   ##
============================================
+ Coverage     17.71%   17.78%   +0.06%     
- Complexity    15858    15985     +127     
============================================
  Files          5926     5928       +2     
  Lines        533613   534389     +776     
  Branches      65285    65392     +107     
============================================
+ Hits          94517    95016     +499     
- Misses       428415   428622     +207     
- Partials      10681    10751      +70     

Flag	Coverage Δ
uitests	3.69% <ø> (-0.01%)	⬇️
unittests	18.86% <17.89%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18929

[DaanHoogland]

clgtm, on style style/maintainability remark:

there is a lot of create msg string/createEvent sequences. Might pay to create a method for readability.

[vladimirpetrov]

@blueorangutan test

[blueorangutan]

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[vladimirpetrov]

LGTM based on manual testing. Tested with different users VMs using host maintenance mode and different negative cases like insufficient capacity, network errors during migration, etc.

[blueorangutan]

[SF] Trillian Build Failed (tid-16799)