Repository navigation
Doc: add missing parameters to the GUC list - #407
Open
kaya-abdullah wants to merge 2 commits into
Open
kaya-abdullah wants to merge 2 commits into
kaya-abdullah wants to merge 2 commits into
Conversation
Add 28 parameters to config-params-guc-list.md in docs/ and versioned_docs/version-2.x/: the six from issue apache#369 that exist in Cloudberry, the log_* parameters other pages already mention, and gp_autostats_mode, gp_vmem_protect_limit, max_statement_mem and statement_mem. Values come from the GUC definitions on main and REL_2_STABLE. The 2.x copy differs where the branches differ: the log_autovacuum_min_duration default, log_statement_stats also conflicting with log_dispatch_stats, and no MERGE in autostats. See: Issue#369 <apache#369>
kaya-abdullah
marked this pull request as draft
October 11, 2026 21:02
…ptions Add the 18 log_* parameters that were still missing, so the list now has all 37 on main and all 36 on REL_2_STABLE. log_startup_progress_interval exists on main only, so only docs/ has it, and the 2.x copy does not list jsonlog for log_destination. Correct descriptions from the previous commit against elog.c: with stderr in log_destination, logging_collector on and gp_log_format csv, messages are written in Cloudberry's CSV format and the other destinations get nothing. Reword log_error_verbosity and log_line_prefix to match, and clarify that the writer worker takes a place in the gp_cached_segworkers_threshold free list. See: Issue#369 <apache#369>
kaya-abdullah
marked this pull request as ready for review
October 11, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #369
Change logs
Adds 46 parameters to the configuration parameter list (
config-params-guc-list.md). Both copies of the page are updated,docs/andversioned_docs/version-2.x/(45 there, see below). The new entries are in alphabetical order and use the same format as the existing ones.What the issue asked for
The issue names 10 parameters and the
log_*group.Added (6): these exist in Cloudberry and were missing from the list.
gp_cached_segworkers_thresholdgp_max_plan_sizegp_max_sliceslock_timeoutmax_locks_per_transactionmax_slot_wal_keep_sizeNot added (4): these do not exist in Cloudberry. None of them is defined as a parameter on
mainor onREL_2_STABLE.gp_add_column_inherits_table_settinggp_resource_group_memory_limitmaster_shared_bufferssegment_shared_buffersThe
log_*group (36 added): Cloudberry has 37log_*parameters onmainand 36 onREL_2_STABLE.log_checkpointswas already in the list, so this adds the other 36 (35 on 2.x):log_autostats,log_autovacuum_min_duration,log_btree_build_stats,log_connections,log_destination,log_directorylog_disconnections,log_dispatch_stats,log_duration,log_error_verbosity,log_executor_stats,log_file_modelog_filename,log_hostname,log_line_prefix,log_lock_waits,log_min_duration_sample,log_min_duration_statementlog_min_error_statement,log_min_messages,log_parameter_max_length,log_parameter_max_length_on_error,log_parser_stats,log_planner_statslog_recovery_conflict_waits,log_replication_commands,log_rotation_age,log_rotation_size,log_startup_progress_interval,log_statementlog_statement_sample_rate,log_statement_stats,log_temp_files,log_timezone,log_transaction_sample_rate,log_truncate_on_rotationNot in the issue (4 added)
These four are not in the issue, but several pages refer to them and they were missing from the list:
gp_autostats_modegp_vmem_protect_limitmax_statement_memstatement_memWhere the values come from
The type, default value, range, unit and setting category of each parameter come from its definition in the source code:
guc_tables.candguc_gp.conmainfordocs/, andguc.candguc_gp.conREL_2_STABLEforversioned_docs/version-2.x/.The two branches differ for six of the new parameters, so the two copies of the page differ in the same places:
log_autovacuum_min_duration: the default is 600000 ms (10 minutes) onmainand -1 (off) on 2.x.log_statement_stats: on 2.x it also cannot be turned on together withlog_dispatch_stats.gp_autostats_mode: on 2.x,MERGEdoes not trigger automatic statistics collection, so the 2.x copy does not mention it.log_destination:jsonlogis a valid destination onmainonly, so the 2.x copy does not list it.log_error_verbosity: for the same reason, the 2.x copy mentionscsvlogoutput only.log_startup_progress_interval: it does not exist on 2.x, so only thedocs/copy has it.