Repository navigation
Release: check the pom.xml version against the release tag - #122
Merged
Merged
Conversation
The release script checked the VERSION file against the tag but never compared it with the <version> in pom.xml, which ships in the source tarball. The go-libs and pxf 2.2.0-incubating-rc2 tarballs went out with pom.xml still at 2.1.0-incubating because their scripts had the same gap; this one was right only because pom.xml had been bumped by hand. Read the project version with xmllint, which the script already requires, and stop unless it is <base version>-incubating. Assisted-by: Claude Code
Member
Author
|
verified: [gpadmin@cdw cloudberry-backup]$ ./cloudberry-backup-release.sh --stage --tag 2.2.0-incubating-rc3 -S -k --repo ~/cloudberry-backup/
INFO: GPG signing has been intentionally skipped (--skip-signing).
=================================================================
>> Platform and Tool Detection
=================================================================
Platform detected: Linux
[OK] SHA-512 tool: sha512sum
[OK] Tar tool: tar
- GPG tool: skipped (--skip-signing enabled)
[OK] XML tool: xmllint
Press Enter or type y/yes to continue, or 'n' to exit: y
=================================================================
>> Validating Version Consistency
=================================================================
Version validation strategy:
Tag: 2.2.0-incubating-rc3
Base version (for source files): 2.2.0
Version consistency verified
Release Tag : 2.2.0-incubating-rc3
Base Version : 2.2.0
VERSION file : 2.2.0
pom.xml : 2.2.0-incubating
Press Enter or type y/yes to continue, or 'n' to exit: y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release script checked the VERSION file against the tag but never compared it with the
<version>in pom.xml, which ships in the source tarball. The go-libs and pxf 2.2.0-incubating-rc2 tarballs went out with pom.xml still at 2.1.0-incubating because their scripts had the same gap; this one was right only because pom.xml had been bumped by hand.Read the project version with xmllint, which the script already requires, and stop unless it is
<base version>-incubating.Assisted-by: Claude Code
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: