Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ip-restrictionpassesremote_addrtomatcher:match()unchanged, andresty.ipmatcheronly checks IPv6 rules for an IPv4-mapped address. When a trusted dual-stack proxy writes the client address as::ffff:10.0.0.5, a blacklist of10.0.0.0/8does not match it, and a whitelist that covers it rejects it.Changes:
core.ip.match_addr(matcher, ip)retries the match with the embedded IPv4 address whenipis IPv4-mapped (::ffff:a.b.c.d, any case, or the hex form::ffff:a00:5).ip-restrictionuses it for both the blacklist and the whitelist.t/plugin/ip-restriction.t(TEST 36-41): mapped and hex-mapped addresses hit an IPv4 blacklist, a mapped address outside it passes, and a mapped address inside an IPv4 whitelist is allowed.Behavior change: a request whose client address is the IPv4-mapped form of an address in an IPv4 rule is now treated like the plain IPv4 address.
Which issue(s) this PR fixes:
Fixes #
Checklist