Repository navigation
fix(apisix): make ingress-controller Admin API access configurable and support IPv6 - #1023
Merged
Merged
Conversation
…troller is enabled Previously 0.0.0.0/0 was always appended to allow_admin when the ingress-controller sub-chart was enabled, which silently overrode any user-defined ipList and never allowed IPv6 clients. ipList now defaults to null. When unset, the chart renders 127.0.0.1/24 and, with ingress-controller enabled, 0.0.0.0/0 and ::/0. When set, the list is used as-is. Fixes apache#921
Replace the implicit 0.0.0.0/0 appended for the ingress-controller with a configurable list that defaults to 0.0.0.0/0 and ::/0. This keeps existing installs working, lets users narrow or disable the extra access, and adds IPv6 support. ipList keeps a concrete default (127.0.0.1/24 and ::1).
AlinsRan
changed the title
nic-6443
approved these changes
Oct 15, 2026
shreemaan-abhishek
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #921
Problem
When
ingress-controller.enabled=true, the ConfigMap template always appended0.0.0.0/0todeployment.admin.allow_admin. Users had no way to narrow the Admin API access granted for the ingress controller, and IPv6 clients were never allowed: on an IPv6 single-stack cluster (apisix.admin.ip: "[::]"), the ingress controller connects from an IPv6 Pod address and gets403.Change
Add
apisix.admin.allow.ingressControllerExtraIpList, the CIDRs appended toipListwhen the ingress-controller sub-chart is enabled:ipListbehavior is unchanged.::/0for IPv6.[]to append nothing.ipListrather than underingress-controller, because it configures APISIX's own Admin ACL and should not share the sub-chart's values namespace.Rendered
allow_admin:127.0.0.1/24127.0.0.1/24,0.0.0.0/0,::/0ipList0.0.0.0/0,::/0ingressControllerExtraIpList: [10.244.0.0/16]127.0.0.1/24127.0.0.1/24,10.244.0.0/16ingressControllerExtraIpList: []127.0.0.1/24127.0.0.1/24ipList: []0.0.0.0/00.0.0.0/0,::/0Compatibility
No breaking change: with ingress-controller disabled the output is identical to master; with it enabled the only addition is
::/0.Verification
helm lintpasses, andhelm templaterenders the expectedallow_adminfor each row in the table above.admin_listen.ip: "[::]"and a remote IPv6 client:allow ::/0passes the ACL, whileallow 0.0.0.0/0andallow ::1both return403(::1only matches loopback). With the default IPv4 admin listener,::/0has no effect.