Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default terminal explorer ignores
--max-items:ShowJSONIteratorpasses the original iterator toExploreJSONStream, which preloads and fetches beyond the requested count. The handlers already pass the correct budget, including the--limitfallback.Wrap only the terminal explorer's iterator with a private lazy cap. It stops before calling the underlying
Next()at the limit, leaves negative budgets unlimited, and passes the original items and errors through. No new public API or flags.Validation on Windows, Go 1.27.2:
46211edand the patched CLI. In an 80x24 ConPTY terminal against a local HTTP fixture serving ten one-item pages,models list --max-items 2fetched/displayed all ten items before the fix and exactly two afterward. Both exited normally.go build ./..., Go formatting andgit diff --checkpass.go test ./... -count=1completed against the pinned local Steady mock: 685 top-level tests passed; four generated download cases failed because they write to/dev/nullon Windows. Each failing command produces the same error on the pristine upstream binary. No tests were disabled or changed to hide these failures.Related: #83 fixes the separate pager loop; #71 addresses other explorer behavior. Neither enforces the item budget in this terminal branch.
No live Claude API calls were made. Prepared with Codex assistance; the diff and terminal HTTP traces were reviewed.