Skip to content

test: allow git dependencies in E2E npm sandbox configuration - #34018

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:git-consume
Sep 3, 2026
Merged

test: allow git dependencies in E2E npm sandbox configuration#34018
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:git-consume

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

No description provided.

@alan-agius4
alan-agius4 requested a review from clydin September 3, 2026 16:22
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the E2E test sandbox setup in tests/e2e/setup/001-npm-sandbox.ts to allow git dependencies consumption by setting the NPM_CONFIG_allow_git environment variable to 'true'. There are no review comments, and I have no feedback to provide.

@alan-agius4
alan-agius4 merged commit 8eed511 into angular:main Sep 3, 2026
18 checks passed
@alan-agius4
alan-agius4 deleted the git-consume branch September 3, 2026 16:24
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants