fix(@angular/build): ensure parent directory exists in SQLite cache store - #34016
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the SQLite cache store by trying to open the database file first, only creating parent directories if that fails. A test was added to verify this behavior. The reviewer suggested checking for the ':memory:' path upfront to avoid an unnecessary try-catch block and prevent masking other errors.
clydin
force-pushed
the
fix/sqlite-cache-parent-dir
branch
from
September 3, 2026 14:17
0dfec97 to
c7f52fc
Compare
clydin
added
target: patch
…tore Previously, initializing DatabaseSync directly with a path in a nonexistent directory failed with an unable to open database file error. Unlike other storage backends, node:sqlite does not recursively create parent directory structures. Parent directories for the cache database are now created recursively before opening the database file, preventing initialization errors when the cache directory does not yet exist.
clydin
force-pushed
the
fix/sqlite-cache-parent-dir
branch
from
September 3, 2026 14:47
c7f52fc to
75fbe7f
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Sep 3, 2026
alan-agius4
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, initializing DatabaseSync directly with a path in a nonexistent directory failed with an unable to open database file error. Unlike other storage backends, node:sqlite does not recursively create parent directory structures.
Parent directories for the cache database are now created recursively before opening the database file, preventing initialization errors when the cache directory does not yet exist.