-
Notifications
You must be signed in to change notification settings - Fork 11.8k
perf(@angular/ssr): pre-compile critical CSS plans at build time #33992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
packages/angular/build/src/utils/server-rendering/manifest_spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| import type { Metafile } from 'esbuild'; | ||
| import { BuildOutputFileType, createOutputFile } from '../../tools/esbuild/bundler-files'; | ||
| import { initializeHash } from '../hash'; | ||
| import { generateAngularServerAppManifest } from './manifest'; | ||
|
|
||
| describe('generateAngularServerAppManifest', () => { | ||
| beforeAll(async () => { | ||
| await initializeHash(); | ||
| }); | ||
|
|
||
| const dummyMetafile = { inputs: {}, outputs: {} } as unknown as Metafile; | ||
|
|
||
| it('should include criticalCssPlans when inlineCriticalCss is true', async () => { | ||
| const additionalHtml = new Map([ | ||
| [ | ||
| 'index.server.html', | ||
| createOutputFile( | ||
| 'index.server.html', | ||
| '<html><body><app-root></app-root></body></html>', | ||
| BuildOutputFileType.ServerApplication, | ||
| ), | ||
| ], | ||
| ]); | ||
| const outputFiles = [ | ||
| createOutputFile('styles.css', 'h1 { color: blue; }', BuildOutputFileType.Browser), | ||
| ]; | ||
|
|
||
| const { manifestContent } = await generateAngularServerAppManifest( | ||
| additionalHtml, | ||
| outputFiles, | ||
| true, | ||
| undefined, | ||
| undefined, | ||
| '/', | ||
| new Set(), | ||
| dummyMetafile, | ||
| undefined, | ||
| ); | ||
|
|
||
| expect(manifestContent).toContain('criticalCssPlans: ['); | ||
| expect(manifestContent).toContain('styles.css'); | ||
| expect(manifestContent).not.toContain('nonce:'); | ||
| }); | ||
|
|
||
| it('should not include criticalCssPlans when inlineCriticalCss is false', async () => { | ||
| const additionalHtml = new Map([ | ||
| [ | ||
| 'index.server.html', | ||
| createOutputFile( | ||
| 'index.server.html', | ||
| '<html><body><app-root></app-root></body></html>', | ||
| BuildOutputFileType.ServerApplication, | ||
| ), | ||
| ], | ||
| ]); | ||
| const outputFiles = [ | ||
| createOutputFile('styles.css', 'h1 { color: blue; }', BuildOutputFileType.Browser), | ||
| ]; | ||
|
|
||
| const { manifestContent } = await generateAngularServerAppManifest( | ||
| additionalHtml, | ||
| outputFiles, | ||
| false, | ||
| undefined, | ||
| undefined, | ||
| '/', | ||
| new Set(), | ||
| dummyMetafile, | ||
| undefined, | ||
| ); | ||
|
|
||
| expect(manifestContent).not.toContain('criticalCssPlans:'); | ||
| }); | ||
|
|
||
| it('should extract template nonce from index HTML when present', async () => { | ||
| const additionalHtml = new Map([ | ||
| [ | ||
| 'index.server.html', | ||
| createOutputFile( | ||
| 'index.server.html', | ||
| '<html><body><app-root ngCspNonce="{% nonce %}"></app-root></body></html>', | ||
| BuildOutputFileType.ServerApplication, | ||
| ), | ||
| ], | ||
| ]); | ||
| const outputFiles = [ | ||
| createOutputFile('styles.css', 'h1 { color: blue; }', BuildOutputFileType.Browser), | ||
| ]; | ||
|
|
||
| const { manifestContent } = await generateAngularServerAppManifest( | ||
| additionalHtml, | ||
| outputFiles, | ||
| true, | ||
| undefined, | ||
| undefined, | ||
| '/', | ||
| new Set(), | ||
| dummyMetafile, | ||
| undefined, | ||
| ); | ||
|
|
||
| expect(manifestContent).toContain('nonce: "{% nonce %}"'); | ||
| }); | ||
|
|
||
| it('should not include css files in serverAssetsChunks or assets', async () => { | ||
| const additionalHtml = new Map([ | ||
| [ | ||
| 'index.server.html', | ||
| createOutputFile( | ||
| 'index.server.html', | ||
| '<html><body></body></html>', | ||
| BuildOutputFileType.ServerApplication, | ||
| ), | ||
| ], | ||
| ]); | ||
| const outputFiles = [ | ||
| createOutputFile('styles.css', 'h1 { color: blue; }', BuildOutputFileType.Browser), | ||
| ]; | ||
|
|
||
| const { manifestContent, serverAssetsChunks } = await generateAngularServerAppManifest( | ||
| additionalHtml, | ||
| outputFiles, | ||
| true, | ||
| undefined, | ||
| undefined, | ||
| '/', | ||
| new Set(), | ||
| dummyMetafile, | ||
| undefined, | ||
| ); | ||
|
|
||
| expect(serverAssetsChunks.some((chunk) => chunk.path.includes('styles'))).toBeFalse(); | ||
| expect(manifestContent).not.toContain("'styles.css':"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.