Repository navigation
Fix release preparation for binary Illustrator artwork - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.2.0 preparation fails with
UnicodeDecodeErrorwhile readinggit diff: Illustrator documents contain binary data but Git's automatic detection treats the PDF-compatible.aimaster as text.Mark
*.aias binary in.gitattributes, keeping binary payloads out of release-note diffs. Add a regression test using a real Git repository with a non-UTF-8 Illustrator file and an ordinary SVG change.Validation: reproduced the failure before the fix; the actual
v1.1.0..HEADdiff now decodes successfully. All 13 release automation tests and the complete Fastlane Python checks pass.Stabilize the API 35 device test by explicitly hiding the keyboard and waiting until it is hidden before leaving the edited field, then asserting the Journal tab is selected before navigating back. The original test passed locally, indicating an intermittent navigation failure. All 11 device tests pass on a disposable API 35 emulator; the affected scenario also passes three consecutive additional runs.
After merging, start a new Prepare and merge release run for
1.2.0on currentmain. Re-running the old run would use its original commit. The failed run created neitherrelease/v1.2.0norv1.2.0.APK artifacts
Built from commit
010e8306by CI run #101.Artifacts expire after 14 days. Neither APK uses the Message487 release key.