Skip to content

conf: discover bundled configuration beside the loaded shared library - #540

Open
Robolightning wants to merge 1 commit into
alsa-project:masterfrom
StableKite:engineering/portable-config-v1.2.14
Open

Robolightning wants to merge 1 commit into
alsa-project:masterfrom
StableKite:engineering/portable-config-v1.2.14

Conversation

@Robolightning

Copy link
Copy Markdown

When a shared ALSA library is distributed with its original configuration tree, the compiled build-machine data directory may be unavailable after relocation. Resolve a readable alsa-config/alsa.conf beside the actually loaded DSO before falling back to the compiled directory. An absolute explicit ALSA_CONFIG_DIR keeps precedence.

Cache an owned path with pthread_once. Resolve the DSO from a static local function address so another globally loaded libasound cannot substitute the lookup target. This does not mutate process environment variables or change PCM plugins, exported symbols, or compiled-directory fallback.

Validated on the v1.2.14 source baseline with the original make check (configuration and MIDI tests), all 1,835 exported SDK symbols unchanged, and real null/plug:null PCM I/O: four threads, 32,768 frames per case. Separate native processes checked relocated default, explicit user directory, compiled fallback, and explicit-handle use alongside an older globally loaded library. The private producer used the existing --enable-symbolic-functions option; no data-symbol binding change is proposed.

The scope is SDK configuration discovery. An unrelated Python extension's external calls can still resolve to an older library explicitly preloaded RTLD_GLOBAL; this change makes no claim to isolate those calls. Physical sound hardware was unavailable.

@github-actions github-actions Bot added the signed off by Missing Signed-off-by: line. label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

⚠️ Signed-off-by Validation Issues

The following commits have issues with their Signed-off-by lines:

Commit 8e9b59b

Author: Robolightning irobolightning@gmail.com
Committer: Robolightning irobolightning@gmail.com
Signed-off-by lines: (none found)

Issues:

  • Missing Signed-off-by line

Each commit must include a proper Signed-off-by: Your Name <your.email@example.com> line. Additionally, both the commit author and committer emails must either match one of the Signed-off-by lines or use a valid (non-anonymous) email address.

Tip: You can inspect your commits locally using:

git log --format=fuller

Missing correct Signed-off-by line

This pull request has commits that are missing proper Signed-off-by lines or use invalid email addresses.

Requirements:

  • Each commit must include at least one Signed-off-by: Your Name <your.email@example.com> line
  • Commit author email must appear in at least one Signed-off-by line
  • Commit committer email must appear in at least one Signed-off-by line (if not a GitHub bot)
  • Multiple Signed-off-by lines are allowed for co-authored commits
  • Anonymous GitHub emails (like @users.noreply.github.com) are not allowed
  • The Signed-off-by line indicates that you agree to the Developer Certificate of Origin (DCO)

How to fix:

# 1. Configure your git identity first (if needed):
git config user.name "Your Name"
git config user.email "your.email@example.com"

# 2. For adding Signed-off-by to the last commit:
git commit --amend --signoff

# 3. For adding Signed-off-by to multiple commits:
git rebase -i HEAD~N --signoff

# 4. If commit author email is wrong, fix it:
# For the last commit only:
git commit --amend --author="Your Name <your.email@example.com>" --signoff

# For multiple commits:
git rebase -i HEAD~N
# Mark commits as 'edit', then for each:
git commit --amend --author="Your Name <your.email@example.com>" --signoff
git rebase --continue

# 5. For co-authored commits, add multiple Signed-off-by lines manually:
git commit --amend
# Then add in the commit message:
# Signed-off-by: Author One <author1@example.com>
# Signed-off-by: Author Two <author2@example.com>

# 6. Finally, force push your changes:
git push --force-with-lease

Reference: Developer Certificate of Origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

signed off by Missing Signed-off-by: line.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant