Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Git-tracked dangling symlink needed by generated Swift bindings is absent from the remote workspace after sync. The local link exists before
target/bindingsdoes; the build creates that target later, and SwiftPM then needs the original link identity to resolve the generated file.Change
SyncRequest; partial syncs do not claim ownership of the full link set.120000entries from Git, keeps the original relative targets, and excludes link aliases from the regular file manifest so a followed file link cannot overwrite its link.Reproduce and verify
Mitts Build 0.3.21, macOS ARM64:
mitts test --locked -p prod-code-protocol --test transport_security_acceptance test_packet_capture_wire_confidentiality— 1 passed.mitts test --locked -p prod-code-gateway --lib 'sync::symlinks::tests::'— 2 passed. Covers dangling-link identity after the generated target appears, removal of a managed link, workspace-escape rejection, and the response acknowledgement.mitts test --locked -p prod-code-mcp --lib 'sync::push::tests::'— 6 passed. Covers sending tracked links, filtering a followed file link from ordinary file deltas, and refusing a legacy gateway before command execution.mitts test --locked -p prod-code-testkit --test wire_and_engines_1_scripted_gateway sync_messages_are_answered_as_if_the_tree_were_held— 1 passed.prod-code-gateway,prod-code-mcp,prod-code-protocol, andprod-code-testkit— passed with 0 diffs.prod-code-protocol. Strict Clippy for gateway and MCP is blocked by existing warnings in unrelated modules; one warning in the new gateway helper was fixed. No claim of a clean strict-Clippy run for those packages.No performance claim. A live SwiftPM remote-exec run has not yet been done; the regression is covered by focused client and gateway tests, not a released-cluster test.
Measurements
None; no latency or performance claim.
Checks
The targeted Mitts tests above passed. No full test suite or live cluster was run.
Closes
Closes #1889