Repository navigation
fix(lint): repair ruff findings in scripts/real-history (Refs #891) - #892
Closed
alex-mextner wants to merge 1 commit into
Closed
alex-mextner wants to merge 1 commit into
alex-mextner wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded by #893 (e05e318, Refs #890), which repaired the same real-history lint findings and split build_real_corpus.py. On main |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint-only, behavior-preserving repair of the ruff findings that arrived in scripts/real-history with the intent engine PR 859. Refs #891, Refs #860.
What changed: unused noqa comments removed (RUF100), imports sorted (I001), collections.abc import (UP035), unquoted annotation (UP037), str.split calls replaced by list literals with identical values and order (SIM905, which makes ruff format expand pools.py and the test vocabulary one string per line), two open calls moved under context managers (SIM115), ruff format. No ruff ignores, config or scrub logic touched, nothing moved between files.
Proof: whole-repo ruff check and ruff format --check clean (ruff 0.16.10 locally); rig lint run --skip typecheck --no-setup complete, 7 of 7 applicable passed, 0 uncovered files; test_scrub.py 12 tests OK before and after. pools.py and test_scrub.py are AST-identical once the split calls are folded to lists; scrub.py differs only in the import source and a removed comment; build_real_corpus.py differs in imports order, the two context managers and one unquoted annotation.
Left alone: build_real_corpus.py (1461 lines) and seed-calendar.ts stay over the 1200 line warning, for the owner.