Skip to content

fix(lint): repair ruff findings in scripts/real-history (Refs #891) - #892

Closed
alex-mextner wants to merge 1 commit into
mainfrom
fix-real-history-lint
Closed

alex-mextner wants to merge 1 commit into
mainfrom
fix-real-history-lint

Conversation

@alex-mextner

Copy link
Copy Markdown
Owner

Lint-only, behavior-preserving repair of the ruff findings that arrived in scripts/real-history with the intent engine PR 859. Refs #891, Refs #860.

What changed: unused noqa comments removed (RUF100), imports sorted (I001), collections.abc import (UP035), unquoted annotation (UP037), str.split calls replaced by list literals with identical values and order (SIM905, which makes ruff format expand pools.py and the test vocabulary one string per line), two open calls moved under context managers (SIM115), ruff format. No ruff ignores, config or scrub logic touched, nothing moved between files.

Proof: whole-repo ruff check and ruff format --check clean (ruff 0.16.10 locally); rig lint run --skip typecheck --no-setup complete, 7 of 7 applicable passed, 0 uncovered files; test_scrub.py 12 tests OK before and after. pools.py and test_scrub.py are AST-identical once the split calls are folded to lists; scrub.py differs only in the import source and a removed comment; build_real_corpus.py differs in imports order, the two context managers and one unquoted annotation.

Left alone: build_real_corpus.py (1461 lines) and seed-calendar.ts stay over the 1200 line warning, for the owner.

@alex-mextner

Copy link
Copy Markdown
Owner Author

Superseded by #893 (e05e318, Refs #890), which repaired the same real-history lint findings and split build_real_corpus.py. On main ruff check scripts/real-history reports 'All checks passed' and ruff format --check '8 files already formatted', so nothing is left for this PR. Ticket #891 stays open for its remaining acceptance proofs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant