Repository navigation
Update all package dependencies to latest versions - #37
Merged
Merged
Conversation
Bump every outdated NuGet package, MSBuild SDK and .NET tool: - Auth0.ManagementApi 9.2.0 -> 10.1.0 - Auth0.AuthenticationApi 7.48.0 -> 7.49.0 - KubeOps.Operator/.Generator/.Operator.Web 13.1.0 -> 13.2.0 - KubeOps.Cli (dotnet tool) 13.1.0 -> 13.2.0 - Microsoft.CodeAnalysis.CSharp 5.6.0 -> 5.9.0 - System.Reflection.MetadataLoadContext 10.0.10 -> 10.0.11 - System.Text.Json 10.0.10 -> 10.0.11 - System.Threading.RateLimiting 10.0.10 -> 10.0.11 - MSTest.Sdk 4.3.3 -> 4.4.0 IKVM.Core.MSBuild, Newtonsoft.Json, YamlDotNet, Microsoft.Build.NoTargets and GitVersion.Tool were already at their latest releases, as were the workflow's GitHub Actions. No source changes were required. The Auth0 major bump is the only breaking one, and its single breaking change - date fields on session, refresh token and flow responses moving from nullable to Optional<T> - lands entirely on endpoints this operator does not call; it drives Clients, Connections, ResourceServers, ClientGrants, Roles, Branding, CustomDomains, Tenants and Prompts. The reflective lookup of Auth0.ManagementApi.Core.JsonOptions still resolves under 10.1.0. KubeOps 13.2.0 infers RBAC scope from AddKubernetesOperator: it emits a namespaced Role only when OperatorSettings.Namespace is a compile-time constant. This operator never sets it, so generation stays cluster-wide and the chart's committed clusterrole.yaml needs no resync.
The 13.2.0 KubeOps CLI dies partway through generation:
Generate CRDs.
Unhandled exception: System.IO.FileNotFoundException: Could not find assembly
'Microsoft.CodeAnalysis, Version=5.9.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
and then exits 0. Nothing fails: MSBuild sees a successful Exec, config/ is left
empty, and the chart's RewriteCrds skips every CRD through its Exists() condition,
so helm packages a chart carrying templates and a ClusterRole but no CRDs at all.
The build is green and the artifact is broken - the charts artifact fell from
109,942 to 39,178 bytes against the previous pull request build.
Revert KubeOps.Operator, KubeOps.Generator, KubeOps.Operator.Web and the
KubeOps.Cli tool to 13.1.0, the version main already ships, and record the reason
beside the reference so a future bump is checked against the chart size rather
than the exit code. Every other package in the previous commit stays updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps every outdated NuGet package, MSBuild SDK and .NET tool in the repository, except KubeOps — see below. No source changes were required.
Updated
global.json)Held back: KubeOps stays at 13.1.0
13.2.0 is available and this PR originally took it. It silently ships a chart with no CRDs. The CLI dies partway through generation and then exits 0:
Nothing fails as a result. MSBuild sees a successful
Exec,config/is left empty, and the chart'sRewriteCrdsskips every CRD through itsCondition="Exists(...)", sohelm packageproduces a chart with templates and a ClusterRole but no CRDs. The build stays green and only the artifact size gives it away — thechartsartifact fell from 109,942 bytes (PR #36, KubeOps 13.1.0) to 39,178 bytes on the first commit here.KubeOps.Operator,KubeOps.Generator,KubeOps.Operator.Weband theKubeOps.Clitool are therefore all reverted to 13.1.0, the versionmainalready ships, with the reason recorded beside the reference so a future bump is checked against the chart contents rather than the exit code.Already current — verified, not changed
IKVM.Core.MSBuild (0.1.108), Newtonsoft.Json (13.0.4), YamlDotNet (18.1.0), Microsoft.Build.NoTargets (3.7.134), GitVersion.Tool (6.8.2), and the workflow's GitHub Actions (
checkout@v7,setup-dotnet@v6,upload-artifact@v7,download-artifact@v8) are all at their latest releases.global.json's SDK pin stays at10.0.100withrollForward: latestFeature, which already picks up newer patches.Compatibility review
Auth0.ManagementApi 10.x is the only major bump. Its sole breaking change is date-valued properties on refresh-token, session and flow responses moving from
T?toOptional<T?>—GetRefreshTokenResponseContent,SessionResponseContent,SessionAuthenticationSignal.Timestamp,FlowActionFlowMapValueParams.Fallbackand friends. The operator drives Clients, Connections, ResourceServers, ClientGrants, Roles, Branding, CustomDomains, Tenants and Prompts, and touches none of those endpoints, so nothing needed adapting. TheOptional<T>type itself was already in use in the connection mapping, so the pattern is unchanged.The reflective lookup of the internal
Auth0.ManagementApi.Core.JsonOptions(inV2alpha3ConnectionController,ConnectionConverterandClientConverter) still resolves under 10.1.0 — the type and itsJsonSerializerOptionsfield both survive the major bump. Because it is read from a static field initializer, the mapping tests would fail with aTypeInitializationExceptionif it had not.Verification
Releasebuild: 0 errors, 0 new warnings (the twoNU1510"will not be pruned" notices forSystem.Text.JsonandSystem.Threading.RateLimitingpre-date this change).dotnet test.helmunavailable; the KubeOps CLI fails to resolve the project-referencedAlethic.Auth0.Operator.Coreassembly under a distro-packaged SDK, on 13.1.0 and 13.2.0 alike). They are verified through CI instead, by checking thechartsartifact is full size rather than trusting the job's exit code.