Repository navigation
The load test asks for a clear rise in throughput, not a multiple - #26
Merged
Merged
Conversation
On a slow shared build machine the overhead of each call takes most of what a higher limit allows: the limit rose 2 to 6 and throughput 1.46 times, under the 1.5 the test asked for, where this machine shows 2.7. The claim is that the rise bought throughput; 1.2 says so and a flat result does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carried over from after #25 merged.
On a slow shared build machine (the macOS x64 runner) the overhead of each call takes most of what a higher limit allows: in one run the limit rose 2 to 6 and throughput 1.46 times, under the 1.5 the test asked for, where a desktop shows 2.7. The claim is that the rise bought throughput; 1.2 says so and a flat result does not. The three runs since passed on that margin by luck, not a fix.