Repository navigation
Give each test session its own tmp root - #146
Merged
Merged
Conversation
Test dirs lived at fixed /tmp/picopt-tests.<module> paths, so concurrent `make test` runs from different worktrees set up and tore down each other's files, failing with spurious FileNotFoundErrors. Create the root once per session with tempfile.mkdtemp and remove it at exit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/picopt-tests.<module>paths, so concurrentmake testruns from different git worktrees set up and tore down each other's files (~30 spuriousFileNotFoundErrors intest_images_dir.py/test_containers.py).tests/__init__.pynow createsTMP_ROOTonce per session withtempfile.mkdtemp(prefix="picopt-")and removes it at exit. Module dirs become$TMPDIR/picopt-XXXXXXXX/tests.<module>.# noqa: S108. No test modules or assertions change; every module already gets its dir fromget_test_dir().Test plan
make fix,make lint,make tycleanmake test: 424 passed, 6 skippedmake testruns concurrently from two worktrees: both passed (422 passed, 6 skipped each, on the pre-Keep a directory config's dry_run from turning a tree's timestamps off #144 base), with simultaneous snapshots showing both runs intest_containers/test_images_dirat once under separate roots🤖 Generated with Claude Code