fix(ci): fix daily Sentry monitor slug and move crons off minute 0 - #717
fix(ci): fix daily Sentry monitor slug and move crons off minute 0#717arne-aignx wants to merge 2 commits into
Conversation
The daily workflow checked in to the monitor slug scheduled-testing-<env>-hourly with schedule "0 12 * * *". Each daily run overwrote the hourly monitor's schedule, and the next hourly run set it back. Use the slug scheduled-testing-<env>-daily instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @arne-aignx's task in 2m 2s —— View job PR Review Complete: Fix Sentry Daily Monitor Slug ✅SummaryThis PR correctly fixes a Sentry monitor slug conflict where daily scheduled tests were checking into the hourly monitor, causing schedule flip-flops and spurious alerts. Critical Checks
AnalysisChanged: - scheduled-testing-${{ inputs.platform_environment }}-hourly
+ scheduled-testing-${{ inputs.platform_environment }}-dailyVerification:
Why Documentation Update Not Required: FindingsNone! This is an excellent, minimal fix that:
RecommendationsNone - this PR is ready to merge as-is. Verdict: ✅ |
…rgin GitHub documents that schedule events are delayed most at the start of every hour. Move the hourly test crons to minute 17, the daily test crons to 12:31 UTC, and the audit cron to minute 43. Align the Sentry monitor schedules and raise the check-in margin from 30 to 60 minutes so normal scheduling jitter does not alert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (64.46%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.
|
|



Why?
The scheduled-test monitoring raises false alerts for two reasons. (1) The daily workflow checks in to the Sentry cron monitor
scheduled-testing-<env>-hourlywith schedule0 12 * * *, so each daily run overwrites the hourly monitor's schedule and the daily tests have no monitor of their own. (2) All scheduled crons fire at minute 0, which GitHub documents as the peak-load time whenscheduleevents are delayed most; a 30-minute Sentry check-in margin then alerts on normal jitter.How?
Change the daily monitor slug to
scheduled-testing-<env>-daily(sentry-cli monitors runcreates it on first check-in). Move the hourly test crons to minute 17, the daily test crons to 12:31 UTC, and the audit cron to minute 43; align the Sentry--schedulestrings and raise--check-in-marginto 60. Update the schedule table and prose in.github/CLAUDE.md.After merge (todo)
scheduled-testing-<env>-dailymonitors appear after the first daily run and that the-hourlymonitors show schedule17 * * * *.