Repository navigation
Release: GoReleaser fills the workflow's draft - #27
Merged
Merged
Conversation
GoReleaser looks up an existing draft by name; its default name is the tag, while release.yml names the draft "light-tokenmeter X.Y.Z". In 1.1.0 the archives went to a second draft and the published release had none. Publishing now stops when the release has no checksums.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v1.1.0 GoReleaser did not find the draft that
release.ymlcreated: it looks up a draft by name (findDraftRelease:r.GetDraft() && r.GetName() == name), its default name is the tag (v1.1.0), and the workflow names the draftlight-tokenmeter 1.1.0. So the archives,checksums.txtand SBOMs went to a second draft and the published release had none..goreleaser.yaml:release.name_template: "light-tokenmeter {{ .Version }}", the workflow's name.release.yml:publishstops when the release has nochecksums.txt, so an empty release is never published again.v1.1.0 itself is repaired by hand: the 10 files were copied to the published release (sums and the cosign bundle verified). The stray draft
v1.1.0is still there and can be deleted.