Repository navigation
Allocate record admission and parser defense controls by stage - #496
Merged
Merged
Conversation
kreneskyp
force-pushed
the
spec/ir-17-record-stage-allocation
branch
from
October 21, 2026 18:48
0274775 to
94e6294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FR-018 still treats duplicate record fields and malformed optional wrappers as if both could be successful source/context inputs to public CG generation. The owning checker rejects duplicate declarations before context creation, and its emitter derives the canonical optional wrapper from admitted Presence. This spec-only amendment makes those stages explicit without dropping their precise defenses.
Only FR-018 and TC-029 change:
Owning source grounding in the inspected QSL composite-facade implementation:
Validation: installed Quire validation passes both documents, diff whitespace checks pass, and bounded advisor reports AC-8/AC-26 Test as catalogued with no mismatch or inconclusive result. Programmatic comparison confirms AC-8’s oracle clause and unrelated AC-9/14/16/24/27/42 rows unchanged. No product/dependency/lock edits, Cargo, formatter, build, native, proof or aggregate jobs ran. This PR does not close IR-17 or IR-705.
Review fix: the initial draft incorrectly required an internal assembly cause through the public facade. The same-PR correction now requires only the actual public AmbiguousDeclaration code and None cause, retaining the precise private DuplicateMember defense and all source-before-context behavior. No new owner API or internal dependency is introduced. The gap report remains 314 obligations (311 baseline, two IR-621, one planned IR-17 AC-8), with recorded owners; this documentation fix deletes no test and claims no green implementation result.