Repository navigation
chore: dongnelibrary 0.7.0 반영 (동작구통합도서관, 문경시립도서관) - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dongnelibrary 0.7.0 을 반영한다. 동작구통합도서관(
dongjak, 11곳)과 문경시립도서관(mungyeong, 10곳)이getLibraryModules()로 들어온다. 모듈은 68개에서 70개가 된다.Changes
package.json:dongnelibrary^0.6.0 → ^0.7.0. lock 의 하위 의존성이 줄어든 것은 dongnelibrary 0.7.0 에서async를 빼고configstore를 8 로 올린 영향이다(CLI 전용, 서버는 쓰지 않음).src/data/libraryRegions.json:scripts/build-library-regions.py를 전국도서관표준데이터 CSV 로 다시 돌려 만들었다. 기존 매핑은 그대로이고 두 모듈만 추가됐다.Test Plan
npm run typecheck통과npm test: 서버 32/32, 웹 232/232 통과 (갱신 전에는 "모든 도서관에 지역 매핑이 있다" 가 21곳 누락으로 실패)/moduleList에 두 모듈이 있는 것을 확인했다