Skip to content

ci(intent): don't ask for review of bump files and the changelog - #59

Merged
adrianbrowning merged 1 commit into
mainfrom
ci/intent-ignore-release-bookkeeping
Oct 8, 2026
Merged

adrianbrowning merged 1 commit into
mainfrom
ci/intent-ignore-release-bookkeeping

Conversation

@adrianbrowning

Copy link
Copy Markdown
Owner

Summary

The Version Packages PR (#27) fails Check Skills → Validate intent skills at intent maintainer check, with 26 pending review items. Run: https://github.com/adrianbrowning/mdcode-ts/actions/runs/37756467376/job/113242139093

That PR deletes 25 .bumpy/*.md files and writes packages/mdcode/CHANGELOG.md. Intent wants a recorded review for every file a PR changes, even files no skill maps. On feature PRs we recorded the bump file by hand as "out-of-scope". Bumpy's bot regenerates the version branch and nobody records anything there, so every Version Packages PR would fail this check.

 _artifacts/skill_tree.yaml
+review:
+  ignore: [ '.bumpy/**', 'packages/mdcode/CHANGELOG.md' ]

Intent's review.ignore stops listing these paths as unmapped changes. Neither one feeds the skill's guidance. Skill sources (src/, the README, examples, the task check) are still reviewed on every PR, the version PR included.

Evidence

I ran intent maintainer check --base origin/main in a worktree of origin/bumpy/version-packages:

  • Before: exit 1, 26 pending review item(s): the 25 bump files plus packages/mdcode/CHANGELOG.md.
  • With this skill_tree.yaml: the only item left is the change to skill_tree.yaml itself, which this PR records. Once this merges, that file isn't in the version PR's diff any more.

On this branch: intent maintainer check --base origin/main shows 0 pending, and pnpm check passed (pre-push).

Merge Danger

Door: two-way

Blast Radius: CI

Feature PRs no longer ask for a review of their bump file. Nothing else changes. #27 should go green once bumpy regenerates it after this merges.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

⚠️ ESLint Check Warnings

Click to see details

Style


> mdcode@0.0.1 lint:s /home/runner/work/mdcode-ts/mdcode-ts
> pnpm -r lint:s

Scope: 2 of 3 workspace projects
packages/mdcode lint:s$ eslint --config .eslintrc.style.json "src/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/mdcode lint:s: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/mdcode lint:s: Done
packages/usage lint:s$ eslint --config .eslintrc.style.json "{tests,fixtures,examples}/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/usage lint:s: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/usage lint:s: Done

Correctness


> mdcode@0.0.1 lint:esl /home/runner/work/mdcode-ts/mdcode-ts
> pnpm -r lint:esl

Scope: 2 of 3 workspace projects
packages/mdcode lint:esl$ eslint "src/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/mdcode lint:esl: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/mdcode lint:esl: Done
packages/usage lint:esl$ eslint "{tests,fixtures,examples}/**/*.{j,t}s{,x}" --cache --max-warnings=0
packages/usage lint:esl: [baseline-browser-mapping] The data in this module is over two months old.  To ensure accurate Baseline data, please update: 'npm i baseline-browser-mapping@latest -D'
packages/usage lint:esl: Done

View workflow run

@adrianbrowning
adrianbrowning merged commit 238c32e into main Oct 8, 2026
8 checks passed
@adrianbrowning
adrianbrowning deleted the ci/intent-ignore-release-bookkeeping branch October 8, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant