Repository navigation
ci(intent): don't ask for review of bump files and the changelog - #59
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Version Packages PR (#27) fails Check Skills → Validate intent skills at
intent maintainer check, with 26 pending review items. Run: https://github.com/adrianbrowning/mdcode-ts/actions/runs/37756467376/job/113242139093That PR deletes 25
.bumpy/*.mdfiles and writespackages/mdcode/CHANGELOG.md. Intent wants a recorded review for every file a PR changes, even files no skill maps. On feature PRs we recorded the bump file by hand as "out-of-scope". Bumpy's bot regenerates the version branch and nobody records anything there, so every Version Packages PR would fail this check.Intent's
review.ignorestops listing these paths as unmapped changes. Neither one feeds the skill's guidance. Skill sources (src/, the README, examples, the task check) are still reviewed on every PR, the version PR included.Evidence
I ran
intent maintainer check --base origin/mainin a worktree oforigin/bumpy/version-packages:26 pending review item(s): the 25 bump files pluspackages/mdcode/CHANGELOG.md.skill_tree.yaml: the only item left is the change toskill_tree.yamlitself, which this PR records. Once this merges, that file isn't in the version PR's diff any more.On this branch:
intent maintainer check --base origin/mainshows 0 pending, andpnpm checkpassed (pre-push).Merge Danger
Door: two-way
Blast Radius: CI
Feature PRs no longer ask for a review of their bump file. Nothing else changes. #27 should go green once bumpy regenerates it after this merges.