Repository navigation
chore: release package (beta) - #3521
Merged
Merged
Conversation
|
Ladon does not review bot-authored PRs. |
bokelley
approved these changes
Oct 30, 2026
bokelley
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the exact generated release head against main 0c4daa6. Both SDK fix merge commits are ancestors, and both release notes are archived unchanged under the CLI 3 pre-mode directory and included in the changelog. The immediate 17.0.0-beta.6 to 17.0.0-beta.7 increment is consistent across package, lock, shim dependency, generated version constants and docs. ADCP_VERSION, compatible protocol releases and beta pre-mode remain unchanged. The ten-file diff contains no runtime behavior changes or source/schema deletions. Independent release review reached the same result. Approval covers this metadata diff; normal required CI must still pass before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
mainis currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exitonmain.Releases
@adcp/sdk@17.0.0-beta.7
Minor Changes
collect_product_pagesstoryboard steps for complete wholesale product reads. The runner requires fresh reads without an idempotency key, preserves the other authored request fields, validates every physical page and its invariants, follows stable feed cursors with bounded restarts and safety limits, and exposes an explicitly labelled logical product view alongside actual per-page evidence. The intrinsiccollect_product_pages_runnerrequirement prevents older runners from silently grading only the first page.Patch Changes
179017a: Fix false-positive
get_productsconformance grades for existing discovery filter requirements. Supplied pricing-currency filters now check every returned media price and observable compulsory product-scoped signal charge, while permitting account-specific FX conversion and optional foreign-currency add-ons. Custom signal pricing whose incremental charge cannot be established is reported as unproven instead of being assumed incompatible. Fixture discovery also respects the negotiated canonical creative capability rather than forcing canonical wire mode on legacy-only AdCP 3.1 sellers.Validate supplied standard and vendor required-metric filters against every returned product, respecting implicit metrics, documented derivations and numeric container subsumption. Vendor and metric pins must match the same declared vendor metric; absent filters impose no optional-feature requirement and valid empty matches remain allowed.
These default-on checks correct previously missed protocol violations: a result that leaks a non-requested media currency or lacks a requested metric can now fail conformance. They do not add optional-feature requirements to unfiltered discovery or change production client requests.