Repository navigation
fix(canonical-formats): forward projection and narrowing repairs to next - #1759
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean forward-port of the #1757/#1758 canonical-format repairs to the SDK 10 / next line.
Checked:
- No findings at any severity (Critical/High/Medium/Low all clear).
- high_risk: false; gated_paths: false; no no-auto-approve team match; no prior decision.
- Reviewer traced the new interval/dedup path in check_narrows against all shipped vectors (None-bound handling, exact-vs-range double-count suppression, numeric guards), the v2→v1 operator-lookup threading (exceptions propagate, missing entries leave refs unchecked, refs preserved on advisory), and the typed-model path in _v1_version_constraints — all correct and test-pinned.
- New params are additive/backward-compatible; new test fixtures and test files accompany the change.
No decision-table trigger fires (rows 1–8 all pass), so this falls through to row 9 → approve.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — test-only rename, no blocking or medium findings.
This PR's delta since the prior approve is a single test-only change: the helper class _EchoHandler was renamed to _ContextIdEchoHandler in tests/integration/test_a2a_context_id.py, across its definition and all four _running_server(...) call sites. All five references in the base were renamed with no dangling identifier left behind. No source, public surface, or wire shape was touched.
Checks:
- No critical/high findings (decision table row 1 not triggered).
- gated_paths: false, and review_decision is APPROVED regardless (row 2 not triggered).
- high_risk: false — no (deleted)/(modified) sensitive-path triggers (rows 3-5 not triggered).
- Prior decision was
approve, notescalate(row 6 not triggered). - No no-auto-approve team match (row 7 not triggered).
- Zero medium findings (row 8 not triggered).
Falls through to row 9 → approve.
Forward the canonical-format repairs from #1757 and #1758 to the SDK 10 line for AdCP 3.3.
Refs #1750 and #1749. The three source files match the reviewed main fixes. Preserve next’s existing serialization tests; no schema pins, generated models, package versions or dependencies change.
Give the context-ID integration test fixture the unique private name
_ContextIdEchoHandler. This prevents another test module’s_EchoHandlerregistration from hidingcreate_media_buyduring full-suite collection. The test assertions and library behavior are unchanged.Validation
make lint,make typecheck-all, andmake testpassed. 20603 passed, 2810 skipped, 10 deselected, 1 xfailed, 1484 warnings in 4076.94s (1:07:56); coverage 92.19%.3e9ecb82e8103c29cc14cf8ca6175ed71bf68d170ff1020a3065bd2f376e6510).